RFR: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX [v2]

Ioi Lam iklam at openjdk.java.net
Mon Feb 1 20:57:44 UTC 2021


On Mon, 1 Feb 2021 20:29:10 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed macos build
>
> src/java.base/share/native/libjava/check_version.c line 33:
> 
>> 31: DEF_JNI_OnLoad(JavaVM *vm, void *reserved)
>> 32: {
>> 33:     return JNI_VERSION_1_2;
> 
> This leaves an entire file with one trivial function implementation. Can we remove the file and implement  `DEF_JNI_OnLoad()` in `jni_util.h` (or some other existing suitable file) ?

I am not sure if jni_utils.c is the right file (it defines the `JNU_XXX` functions that are used by other shared libraries).

There are other .c files that have trivial `DEF_JNI_OnLoad` functions (e.g., java.base/share/native/libnio/nio_util.c).

@AlanBateman do you have any suggestions?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2338



More information about the build-dev mailing list