RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v6]

[Alan Hayward]

On Tue, 2 Feb 2021 11:56:12 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

> > > > Hello, hsdis is a separate out-of-tree project and is not part of this jep.
> > > 
> > > 
> > > Unless there's something I'm missing it only requires a few lines of change to src/utils/hsdis/makefile (it already has support for macos x86_64)
> > 
> > 
> > I agree with Alan that it makes sense to add this trivial change as part of this PR, if it allows the current hsdis solution to continue working on mac/aarch64.
> > > > support for looking for proper hsdis dylib library was added as part of this jep.
> > > 
> > > 
> > > I'm a little confused. Are you planning on adding a new disassembler?
> > 
> > 
> > @a74nh I think Vladimir is referring to #392. The hsdis "component" has been left behind for a long time, and there are several requests to add new backends, which require a modernized build of hsdis. This is undfortunately not a high-priority project, and has been postponed several times already. :(
> 
> Sorry I was under impression hsdis is not part of openjdk tree.
> 
> Alan, could you please share with us the version of binutils you were using in your test ?
> 

I was just using the latest HEAD:
git clone git://sourceware.org/git/binutils-gdb.git src/utils/hsdis/build/binutils

A slightly safer approach would be to grab the latest release:
https://ftp.gnu.org/gnu/binutils/binutils-2.36.tar.gz


Once hsdis-demo was working for me, for only other oddity I had was that the library needed renaming when copying/linking into the build dir:    jdk/lib/server/libhsdis-aarch64.dylib

-------------

PR: https://git.openjdk.java.net/jdk/pull/2200