RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v4]
Phil Race
prr at openjdk.java.net
Tue Feb 2 23:22:12 UTC 2021
> This completes the desktop module JNF removal
>
> * remove -framework JavaNativeFoundation from make files
>
> * remove #import <JavaNativeFoundation/JavaNativeFoundation.h> from all source files. If needed add import of JNIUtilities.h to get jni.h definitions - better anyway since then it gets the current JDK ones not the ones from the O/S
>
> * replace JNFNSToJavaString with NSStringToJavaString and JNFJavaToNSString with JavaStringToNSString
>
> * replace JNFNormalizedNSStringForPath with NormalizedPathNSStringFromJavaString and JNFNormalizedJavaStringForPath with NormalizedPathJavaStringFromNSString
>
> * replace JNFGet/ReleaseStringUTF16UniChars with direct calls to JNI
>
> * Map all JNFRunLoop perform* calls to the ThreadUtilities versions (the vast majority already did this)
>
> * Redo the ThreadUtilities calls to JNFRunLoop to directly invoke NSObject perform* methods.
>
> * define new javaRunLoopMode in ThreadUtilities to replace the JNF one and use where needed.
>
> * Remove the single usage of JNFPerformEnvBlock
>
> * replace JNFJavaToNSNumber in single A11Y file with local replacement
>
> * replace single usage of JNFNSTimeIntervalToJavaMillis in ScreenMenu.m with local replacement
>
> * remove un-needed JNFRunLoopDidStartNotification from NSApplicationAWT.m
>
> * misc. remaining cleanup (eg missed JNF_CHECK_AND_RETHROW_EXCEPTION)
Phil Race has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
- 8260616: Removing remaining JNF dependencies in the java.desktop module
- 8260616: Removing remaining JNF dependencies in the java.desktop module
- Merge branch 'master' into jnf_string
- 8260616: Removing remaining JNF dependencies in the java.desktop module
- 8260616: Removing remaining JNF dependencies in the java.desktop modul
- 8260616: Removing remaining JNF dependencies in the java.desktop module
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2305/files
- new: https://git.openjdk.java.net/jdk/pull/2305/files/7ea57c85..8a014fa6
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2305&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2305&range=02-03
Stats: 34374 lines in 817 files changed: 13984 ins; 9392 del; 10998 mod
Patch: https://git.openjdk.java.net/jdk/pull/2305.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2305/head:pull/2305
PR: https://git.openjdk.java.net/jdk/pull/2305
More information about the build-dev
mailing list