RFR: 8261211: Zero: alpha builds fail with '-fstack-protector not supported for this target' [v2]

[John Paul Adrian Glaubitz]

On Fri, 5 Feb 2021 10:30:56 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Drop -Werror
>
> Marked as reviewed by ihse (Reviewer).

> > Apparently so. But then again all platforms except alpha has this in recent gcc versions, so I think it was an understandable misunderstanding. :) Do anyone build alpha at any regularity at all? I thought Debian at least did that. But this must have been broken for quite some time?

Yes, we're building Alpha regularly in Debian. Keep in mind that we have additional patches in Debian which may not have been upstreamed yet (in particular on patch for m68k due to the different alignment).

> I discovered it after adding Alpha builds to my CIs, which are supposed to cover me for ongoing Zero maintenance work. So I would be building those regularly :)

Awesome, thanks for adding Alpha to your CI. Much appreciated.

> I just browsed Debian's build logs, and I believe Alpha builds are done with GCC 10 there (is that right, @glaubitz?).

That is correct!

> My CIs build with GCC 9. So maybe this patch would become unnecessary when we move to GCC 10 as default. I can work this around for Alpha builds in my CI, but I was hoping to have the least magical incantation to build cleanly.

I think you should just add a hack to your CI to work around this issue until OpenJDK has moved to gcc-10.

Thanks again for helping with the less common architectures. Much much appreciated and I owe you a beverage of your choice at the next FOSS conference ;-).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2423