RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v3]

Gerard Ziemski gziemski at openjdk.java.net
Mon Feb 8 17:18:42 UTC 2021


On Sat, 6 Feb 2021 00:53:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Lanai PR#175 - 8261304 - aghaisas
>
> The file in `RenderPerfTest` should have a GPLv2 license header (no Classpath). I filed [JDK-8261273](https://bugs.openjdk.java.net/browse/JDK-8261273) and also highlighted a couple examples below.

General comment - I am not sure I like the `MTL` prefix acronym in names (ex. `sun.java2d.metal.MTLVolatileSurfaceManager`).

I think you tried to match the `CGL`, but that is a real acronym that stands for "Core Graphics Layer" (I think).

`MTL` on the other hand is no acronym. I can see `ML` for "Metal Layer" I suppose, but also just `Metal` would work just fine.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2403



More information about the build-dev mailing list