RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v4]
Gerard Ziemski
gziemski at openjdk.java.net
Wed Feb 10 22:33:41 UTC 2021
On Wed, 10 Feb 2021 21:45:37 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> Ajit Ghaisas has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Lanai PR#177 - 8261430 - aghaisas
>> - Lanai PR#176 - 8261399 - jdv
>
> Marked as reviewed by gziemski (Committer).
According to Xcode Instruments leak profile, there are 2 minor memory leaks in the Metal rendering pipeline:
`#1 Malloc 80 Bytes 1 0x7fde0d4247b0 80 Bytes libjava.dylib getStringUTF8`
0 libsystem_malloc.dylib malloc_zone_malloc
1 libsystem_malloc.dylib malloc
2 libjava.dylib getStringUTF8 /Volumes/Work/review/2403/jdk/src/java.base/share/native/libjava/jni_util.c:888
3 libjava.dylib JNU_GetStringPlatformChars /Volumes/Work/review/2403/jdk/src/java.base/share/native/libjava/jni_util.c:917
4 libawt_lwawt.dylib Java_sun_java2d_metal_MTLGraphicsConfig_getMTLConfigInfo /Volumes/Work/review/2403/jdk/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m:151
5 0x11ab08d48
6 0x11ab0250d
`#2 Malloc 80 Bytes 1 0x7fde0d4325a0 80 Bytes libjava.dylib getStringUTF8`
0 libsystem_malloc.dylib malloc_zone_malloc
1 libsystem_malloc.dylib malloc
2 libjava.dylib getStringUTF8 /Volumes/Work/review/2403/jdk/src/java.base/share/native/libjava/jni_util.c:888
3 libjava.dylib JNU_GetStringPlatformChars /Volumes/Work/review/2403/jdk/src/java.base/share/native/libjava/jni_util.c:917
4 libawt_lwawt.dylib Java_sun_java2d_metal_MTLGraphicsConfig_tryLoadMetalLibrary /Volumes/Work/review/2403/jdk/src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m:120
5 0x11ab08d48
6 0x11ab024c8
Those can be handled as a followup issues though if you like, it's only 160 bytes total.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2403
More information about the build-dev
mailing list