RFR: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
Erik Joelsson
erikj at openjdk.java.net
Mon Jan 4 15:18:57 UTC 2021
On Tue, 15 Dec 2020 13:11:30 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> Right now `CompileJavaModules.gmk` contains two different part: one part with the functionality needed to compile a java module, and one part were all special requirements for all modules are listed.
>
> The second part should be removed from `CompileJavaModules.gmk`, and instead listed directly for each individual module in `make/modules/$M/Java.gmk`.
>
> I used a special-written shell script to automatically extract the module-specific part from CompileJavaModules.gmk into the respective Java.gmk files, to avoid risking any hard-to-detect copy/paste errors. After this I did a `sed -i` to remove the module-specific prefix. All this makes me confident that I have correctly moved the variables (I realize this is hard to verify from the patch).
Looks good to me. I assume you have run compare builds on all platforms.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1779
More information about the build-dev
mailing list