RFR: JDK-8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006 [v2]

[Christoph Langer]

On Thu, 7 Jan 2021 09:19:27 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Hello,  for a while the AIX build fails with the following error in the harfbuzz build 
>>     1500-004: (U) INTERNAL COMPILER ERROR while compiling OT::MarkBasePosFormat1::collect_variation_indices(hb_collect_variation_indices_context_t *) const.
>> Compilation ended. Contact your Service Representative and provide the following information: GRARNN: gr29643 is used before it is defined.
>> 
>> This xlc 16 version is used for compiling 
>> bash-4.4$ xlc -qversion
>> IBM XL C/C++ for AIX, V16.1.0 (5725-C72, 5765-J12)
>> Version: 16.01.0000.0006
>> 
>> Solution by IBM compiler support is to use  "-qdebug=necan", this  effectively turns off an optimisation called "Early Re-canonizing" on the harfbuzz lib.
>
> Matthias Baesken has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
> 
>  - Adjust comment
>  - JDK-8258484

Hi Matthias,

looks good to me in principal. I would spell out the abbreviation ICE, though, otherwise somebody reading this later could have difficulties to grok it ;-)

Thanks
Christoph

Maybe better:
Early re-canonizing has to be disabled to workaround an internal XlC compiler error when building libharfbuzz
?

LGTM now :)

-------------

Changes requested by clanger (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1972Marked as reviewed by clanger (Reviewer).