RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy [v3]

[Hao Sun]

On Wed, 6 Jan 2021 04:27:44 GMT, Hao Sun <github.com+16932759+shqking at openjdk.org> wrote:

> Thanks for your comments. @kimbarrett and @navyxliu
> I updated the patch based on my understanding. Please check the latest commit.
> 
> As @kimbarrett mentioned, I suppose there still exist the following problems to be addressed.
> 
> 1. why clang-10 with '-Wdeprecated-copy' does NOT raise warning for class DUIterator. It's weird.
> 2. the assert failure when building with gcc '-fno-elide-constructors'. Might not be related to our patch. (JDK-8259036)
> 3. the implementation of 'operator=' for class DUIterator_Fast might be problematic.

For problem 1, it's due to '-Wdeprecated-copy-dtor'. Please refer to my previous comment for details.
For problem 2, I suppose it's not related to our patch and it would be issued in JDK-8259036.
For problem 3, as clarified by @vnkozlov , the code is correct.

Besides, the pre-submit tests failed due to one GC problem, which seems not related to this patch. See JDK-8258481.

Hence, I wonder if this patch is ready to merge. 
Could you please take another round of review as new commits have been made? @kimbarrett @navyxliu @vnkozlov 
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1874