RFR: 8258925: configure script failed on WSL [v2]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Fri Jan 8 06:07:17 UTC 2021


On Fri, 8 Jan 2021 04:27:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Save original path
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8258925
>>  - 8258925: configure script failed on WSL
>
> make/scripts/fixpath.sh line 152:
> 
>> 150:     # If it fails, try again with an added .exe (needed on WSL)
>> 151:     if [[ $? -ne 0 ]]; then
>> 152:       path="$path.exe"
> 
> This seems to conflict with the logic starting at line #173 below.

I pushed to new commit to save original `$path` and restore it later if the path not found.
Could you review again?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1889



More information about the build-dev mailing list