RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy [v4]

Hao Sun github.com+16932759+shqking at openjdk.java.net
Sat Jan 9 00:29:57 UTC 2021


On Fri, 8 Jan 2021 11:55:21 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> [Can't comment on this inline.] I'd prefer DUIterator_Last::operator= be changed to =default, for consistency with the copy constructor. That would require fixing the return type too.

Thanks for your comment. Agree. Will update the code.

> src/hotspot/share/opto/node.hpp line 1461:
> 
>> 1459:   // initialize to garbage
>> 1460: 
>> 1461:   DUIterator_Last (const DUIterator_Last& that) = default;
> 
> Nit - remove space before parameter list.

Thanks for point it out. Will remove.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1874



More information about the build-dev mailing list