RFR: 8258925: configure script failed on WSL [v4]

Yasumasa Suenaga ysuenaga at openjdk.java.net
Sat Jan 9 14:05:11 UTC 2021


On Sat, 9 Jan 2021 09:22:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactoring
>
> I _think_ this is right but to be honest the multitude of variables adds to the confusion for me.
> 
> David

> > > I think it would be a little cleaner/clearer to use unixpath on line 155.
> > 
> > 
> > We will check the result from `$PATHTOOL` at L154, so I think current location is fine.
> 
> I'm not at all sure what you mean by the reference to PATHTOOL here, so
> to be clear I was suggesting writing line 155 as:
> 
> winpath="$($PATHTOOL -w "$unixpath" 2>/dev/null)"

Ah, I misunderstood.
I fixed it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1889



More information about the build-dev mailing list