RFR: 8259343: [macOS] Update JNI error handling in Cocoa code. [v2]
Phil Race
prr at openjdk.java.net
Mon Jan 11 17:52:19 UTC 2021
On Mon, 11 Jan 2021 05:52:02 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
> Not sure that the check for ExceptionOccurred is needed,
It may not be needed in practice but if the code path is never taken no harm ...
in all other places where we check the ref to methods/field we only check the return value, and if it is null then return immediately assuming that an exception is rased already, for example :
>
> https://github.com/openjdk/jdk/blob/b72de3c5fc99f365e9fb25114ddd28eceddfa6e8/src/java.desktop/windows/native/libawt/windows/awt_Button.cpp#L357
>
> Note that the exception in the static initializer is fatal for the application.
Nothing new here.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1967
More information about the build-dev
mailing list