RFR: 8259343: [macOS] Update JNI error handling in Cocoa code. [v2]

[Phil Race]

On Mon, 11 Jan 2021 05:58:28 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 46:
>> 
>>> 44:               if ((*env)->ExceptionOccurred(env) != NULL) { \
>>> 45:                   (*env)->ExceptionDescribe(env); \
>>> 46:               } \
>> 
>> So the update here is that if we are not on the appkit thread, make sure a java exception is thrown.
>> If we are on the appkit thread, clear any java exception since it isn't going anywhere but do it using
>> describe which prints it.
>
> I read the logic of the method differently, probably the wrong indents?
>   - If we are not on the toolkit thread then
>     - Check ExceptionOccurred -> throw JNU_ThrowInternalError if needed or check exception again ->call ExceptionDescribe
>   - NSException raise at the end.

I have a paren in the wrong place ! I've pushed an update.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1967