RFR: 8259343: [macOS] Update JNI error handling in Cocoa code. [v2]

Phil Race prr at openjdk.java.net
Mon Jan 11 17:52:20 UTC 2021


On Mon, 11 Jan 2021 06:01:36 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> I hadn't noticed that line - and definintely not realised it was recent.
>> I suppose he must have had a way to trigger it.
>> But I don't think it hurts to have both.
>
> I just tried to understand why we need to complicate this, to me, it is unclear why handling the same errors in the NSApplicationAWT.m does not work.

Because of the reason I've said before. That logging in NSApplication AWT is not being seen. Something is swallowing it. So I'd say if anything remove that logging and keep the new one but as I also said it isn't harmful to have provision in case it also logs some case we aren't catching.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1967



More information about the build-dev mailing list