RFR: 8259343: [macOS] Update JNI error handling in Cocoa code. [v3]

Sergey Bylokhov serb at openjdk.java.net
Tue Jan 12 02:34:58 UTC 2021


On Mon, 11 Jan 2021 19:27:12 GMT, Phil Race <prr at openjdk.org> wrote:

>> Proposed updates to JNI error handling.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8259343: [macOS] Update JNI error handling in Cocoa code.

src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 197:

> 195:          }  \
> 196:         if (getenv("JNU_NO_COCOA_EXCEPTION") == NULL) { \
> 197:             [NSException raise:NSGenericException format:@"Java Exception"]; \

How did you check that the logging in the NSApplication was swallowing? Both macro will throw the NSException on the toolkit thread now, does it mean that in both cases the logging in the NSApplication will be ignored/no output?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1967



More information about the build-dev mailing list