RFR: 8259343: [macOS] Update JNI error handling in Cocoa code. [v3]
Sergey Bylokhov
serb at openjdk.java.net
Tue Jan 12 20:06:59 UTC 2021
On Tue, 12 Jan 2021 17:21:53 GMT, Phil Race <prr at openjdk.org> wrote:
>> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 197:
>>
>>> 195: } \
>>> 196: if (getenv("JNU_NO_COCOA_EXCEPTION") == NULL) { \
>>> 197: [NSException raise:NSGenericException format:@"Java Exception"]; \
>>
>> How did you check that the logging in the NSApplication was swallowing? Both macro will throw the NSException on the toolkit thread now, does it mean that in both cases the logging in the NSApplication will be ignored/no output?
>
> See the bug assigned to you that I filed last month : https://bugs.openjdk.java.net/browse/JDK-8258797
> This error should have been logged by that NSApplicationAWT code but was not (and I mean in JDK 16 as well before I started on this) and in JDK 17 it was seen only when adding the new logging.
I have found it down to the absence of NSApplication#reportException() method and logging in it. Ok will update that code later in the separate update.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1967
More information about the build-dev
mailing list