RFR: 8259288: Debug build failure with clang-10 due to -Wimplicit-int-float-conversion
Hao Sun
github.com+16932759+shqking at openjdk.java.net
Thu Jan 14 06:03:03 UTC 2021
On Wed, 6 Jan 2021 06:16:43 GMT, Hao Sun <github.com+16932759+shqking at openjdk.org> wrote:
> Making the conversion explicit would fix it.
>
> Flag '-Wimplicit-int-float-conversion' is first introduced in clang-10.
> Therefore clang-8 and clang-9 are not affected. The flag with similar
> functionality in gcc is '-Wfloat-conversion', but it is not enabled by
> '-Wall' or '-Wextra'. That's why this warning does not appear when
> building with gcc.
>
>
> Note that we have tested with this patch, debug build succeeded with clang-10 on Linux X86-64/AArch64 machines.
> Note that '--with-extra-cxxflags=-Wno-deprecated-copy' should be added when configuration. It's another issue (See JDK-8258010)
Can anyone help to review this trivial patch? Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1956
More information about the build-dev
mailing list