RFR: 8259679: GitHub actions should use MSVC 14.28

[David Holmes]

Hi Aleksey,

On 18/01/2021 11:07 pm, Aleksey Shipilev wrote:
> Current Windows GH Actions fails with:
> 
> configure: using /cygdrive/c/progra~2/micros~1/2019/Enterprise/vc/auxiliary/build/vcvarsx86_amd64.bat
> configure: Setting extracted environment variables for x86_64
> checking that Visual Studio variables have been correctly extracted... ok
> checking for cl... [not found]
> configure: error: Could not find a C compiler.
> configure exiting with result code 1
> 
> I managed to figure out that MSVC build 14.27 is not really available. 14.28 is available instead. Note that Windows AArch64 build block already uses 14.28 in the same manner, so this change not only fixes the GH actions, it also keeps both blocks consistent.

Hard-wiring build numbers seems a maintenance PITA. :( Is there not a 
way to do this that is independent of the actual build installed?

Would it not also be good to add a check for the existence of the build 
that we do hard-wire? That way the problem will be very clear next time.

Cheers,
David

> -------------
> 
> Commit messages:
>   - 8259679: GitHub actions should use MSVC 14.28
> 
> Changes: https://git.openjdk.java.net/jdk/pull/2126/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2126&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8259679
>    Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/2126.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/2126/head:pull/2126
> 
> PR: https://git.openjdk.java.net/jdk/pull/2126
>