RFR: 8260289: Unable to customize module lists after change JDK-8258411

[Andrew Leonard]

On Mon, 25 Jan 2021 13:08:53 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> A problem was found downstream with Eclipse OpenJ9 builds whereby since JDK-8258411 they were unable to extend the module lists.
>> This PR adds a IncludeCustomExtension to the conf/module-loader-map.conf, to enable the module list extension again.
>> 
>> Signed-off-by: Andrew Leonard <anleonar at redhat.com>
>
> make/conf/module-loader-map.conf line 100:
> 
>> 98: # Hook to include the corresponding custom file, if present.
>> 99: $(eval $(call IncludeCustomExtension, conf/module-loader-map.conf)) 
>> 100: 
> 
> Using IncludeCustomExtension is a good idea, but you should to this where module-loader-map.conf is included in common/Modules.gmk, not here. The `*.conf` files are supposed to be formatted as simple configuration files, and not include special make commands.

Ah ok thanks Magnus, didn't realize that, I will update

-------------

PR: https://git.openjdk.java.net/jdk/pull/2219