RFR: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC [v5]
Harold Seigel
hseigel at openjdk.java.net
Mon Jan 25 13:26:46 UTC 2021
On Mon, 25 Jan 2021 07:17:13 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Hi David,
>> The changes look good. Just a couple of nits.
>> 1. Could you add a comment explaining why AIX and BSD have their own version of javaTimeNanos_info().
>> 2. A few copyrights need to be updated to 2021.
>> Thanks, Harold
>
> I don't see any new issues on AIX in our tests with this patch. Thanks for waiting!
Hi David,
I think that os_posix.cpp is a good place to put a comment explaining why AIX and BSD have their own javaTimeNanos_info(). Stating something like "AIX and BSD have their own versions because their implementations of monotonic time have worked on those platforms." seems fine.
Thanks for doing this!
Harold
-------------
PR: https://git.openjdk.java.net/jdk/pull/2090
More information about the build-dev
mailing list