RFR: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m

Phil Race prr at openjdk.java.net
Fri Jan 29 17:25:40 UTC 2021


On Fri, 29 Jan 2021 10:01:42 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This removes the JNF dependency from the jdk.hotspot.agent module.
>> The macro expansions are the same as already used in the Java desktop module - which actually uses a macro
>> still but there there are hundreds of uses.
>> The function of this macro code is to prevent NSExceptions escaping to Java and also to drain the auto-release pool.
>> What test group would be good for verifying this change ?
>
> Build changes look good.

> Is it because they are not in a place that can be accessed from this file?
Right 99% of JNF usage was the desktop module many, many files, 1300 references .. the entire rest of the JDK had just 3 files each in a different module ! It did not seem worth creating a JDK-wide platform-specific library to support this.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2304



More information about the build-dev mailing list