RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain
Denghui Dong
ddong at openjdk.java.net
Fri Jul 2 15:33:18 UTC 2021
Hi,
Could I have a review of this improvement that eliminates 'is_large' if the event size range is certain?
JDK-8246260 introduced event large checks to reduce the recording size.
This check could be eliminated at compile/build time when one of the following conditions is satisfied:
1. if the max size is < 128
2. if the min size is >= 128
The max size and the min size could be computed for the most native events at the generation phase.
And I think this improvement may also be done for JDK events.
-------------
Commit messages:
- format
- trivial update
- init
Changes: https://git.openjdk.java.net/jdk/pull/4670/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4670&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8269823
Stats: 169 lines in 5 files changed: 142 ins; 9 del; 18 mod
Patch: https://git.openjdk.java.net/jdk/pull/4670.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/4670/head:pull/4670
PR: https://git.openjdk.java.net/jdk/pull/4670
More information about the build-dev
mailing list