RFR: 8269823: JFR: Eliminate 'is_large' check for native JFR event if the size range is certain [v3]

Denghui Dong ddong at openjdk.java.net
Tue Jul 6 06:06:13 UTC 2021


> Hi,
> 
> Could I have a review of this improvement that eliminates 'is_large' check if the event size range is certain?
> 
> JDK-8246260 introduced event large checks to reduce the recording size.
> This check could be eliminated at compile/build time when one of the following conditions is satisfied:
> 1. if the max size is < 128
> 2. if the min size is >= 128
> 
> The max size and the min size could be computed for the most native events at the generation phase.
> 
> And I think this improvement may also be done for JDK events.

Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:

  refactor

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4670/files
  - new: https://git.openjdk.java.net/jdk/pull/4670/files/d30f1b6a..fa8c16cb

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4670&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4670&range=01-02

  Stats: 19 lines in 3 files changed: 0 ins; 9 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4670.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4670/head:pull/4670

PR: https://git.openjdk.java.net/jdk/pull/4670



More information about the build-dev mailing list