[jdk17] RFR: 8259848: Interim javadoc build does not support platform links

Erik Joelsson erikj at openjdk.java.net
Tue Jul 13 08:09:49 UTC 2021


On Fri, 9 Jul 2021 20:13:56 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> This patch adds copying of element-list files generated for jdk.javadoc to the interim langtools version of jdk.javadoc. I'm also refactoring the jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra standards as this was missed in the original review of this file. Rebuilding should now work better with the various clean targets and any problems with the generation tool will be captured in separate log files, along with the command lines.
>> 
>> @hns Can you verify that this solves the problem you reported?
>
> make/modules/jdk.javadoc/Gendata.gmk line 86:
> 
>> 84: 	        11 \
>> 85: 	)
>> 86:         # Generate element-list file for the current JDK version
> 
> Is this indentation as intended?

It looks weird in the GitHub web UI. I think they have a different setting for <tab>. We assume 8 spaces for <tab> and align lines that need to be space indented that way. Comments inside recipes need to be space indented so that they are not interpreted as recipe lines.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/227



More information about the build-dev mailing list