RFR: 8271148: static-libs-image target --with-native-debug-symbols=external doesn't produce debug info

Mikael Vidstedt mikael at openjdk.java.net
Thu Jul 22 17:41:01 UTC 2021


On Thu, 22 Jul 2021 16:43:26 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Hi!
> 
> Please review this tiny patch which removes the special casing of `--with-native-debug-symbols=external` for the static libs build. I don't see why this is needed. If no debug symbols are wanted `--with-native-debug-symbols=none` can be used to achieve the same effect. Therefore, I propose to remove this hunk.
> 
> Testing: Inspecting of the log files and seeing that `-g` switch is there. Run the reproducer test on the resulting static libraries.
> 
> Thoughts?

If I understand things correctly (and I may well be misunderstanding something), with this change the debug symbols are included in release versions of the static libraries when --with-native-debug-symbols=external is specified. That's a significant change - people may be depending on debug symbols *not* being included in the resulting release binaries.

Doesn't --with-native-debug-symbols=none turn off debug symbols completely for all native code? What if one wants external debug symbols for other (non-static) libraries?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4876



More information about the build-dev mailing list