RFR: JDK-8271142: package help is not displayed for missing X11/extensions/Xrandr.h [v2]
Christoph Langer
clanger at openjdk.java.net
Fri Jul 23 14:08:30 UTC 2021
On Fri, 23 Jul 2021 14:04:35 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Please review the following change.
>> On SUSE Linux 15 configure was running into this error, because of a missing X11 header :
>>
>> checking for X11/extensions/Xrandr.h... no
>> configure: error: Could not find all X11 headers (shape.h Xrender.h Xrandr.h XTest.h Intrinsic.h).
>>
>> I wondered about the missing package help output, we should display some hint what packages are missing.
>> In help.m4, PKGHANDLER was detected as /usr/bin/zypper .
>> However only the exact string zypper is checked, this should be relaxed.
>> Afterwards, the package - help was working nicely :
>>
>> checking for X11/extensions/Xrandr.h... no
>> configure: error: Could not find all X11 headers (shape.h Xrender.h Xrandr.h XTest.h Intrinsic.h).
>> You might be able to fix this by running 'sudo zypper install libX11-devel libXext-devel libXrender-devel libXrandr-devel libXtst-devel libXt-devel libXi-devel'.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Deal with other package handler tools
Looks good.
-------------
Marked as reviewed by clanger (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4873
More information about the build-dev
mailing list