RFR: 8267706: bin/idea.sh tries to use cygpath on WSL [v2]
Nikita Gubarkov
github.com+9004656+yaaz at openjdk.java.net
Wed Jun 2 00:57:35 UTC 2021
On Wed, 2 Jun 2021 00:19:56 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
>> @jonathan-gibbons this can be fixed with `brew install coreutils`. We probably need to check `realpath` availability in idea.sh and suggest installing `coreutils` if it's not available
>
> @YaaZ I'm aware of the workaround, but the current situation is not acceptable and needs to be fixed. A change to fix functionality on Windows should not adversely affect users on other platforms.
>
> @erikj79 is there precedent for requiring the use of `brew` to install packages?
@jonathan-gibbons sure, but these changes also improve project setup process on all platforms, so realpath is required here because it's needed on MacOS as well, not only Windows
Also, `brew` is already required to instal `autoconf`:
https://openjdk.java.net/groups/build/doc/building.html#autoconf
As `idea.sh` only works when project is configured, running it implies that `brew` is already installed, so asking user to install `coreutils` is not a big deal IMO
-------------
PR: https://git.openjdk.java.net/jdk/pull/4190
More information about the build-dev
mailing list