Integrated: 8268083: JDK-8267706 breaks bin/idea.sh on a Mac

[Nikita Gubarkov]

On Fri, 4 Jun 2021 21:23:27 GMT, Nikita Gubarkov <github.com+9004656+YaaZ at openjdk.org> wrote:

> I got rid of `realpath` usage as discussed in https://github.com/openjdk/jdk/pull/4190 and used `RelativePath` macro instead, however there were quite a few problems with this macro, here's the example:
> 
> $(call RelativePath,/foo/bar,/foo/bar/baz) -> "    ..//foo/bar"
> $(call RelativePath,/foo/bar/baz/,/foo/bar/baz) -> SEGFAULT
> $(call RelativePath,/foo/bar/baz/banan,/foo/bar/) -> "    ./baz/banan"
> $(call RelativePath,/foo/bar/baz,/foo/bar/banan) -> "    ../baz"
> 
> As you can see, 1st case is just plain wrong, 2nd crashes make because of infinite loop, 3rd can be simplified and all of them have leading whitespaces
> First commit in this PR fixes all these issues and adds corresponding test cases and second commit replaces usage of `realpath` in idea.sh with `RelativePath` macro in idea.gmk and fixes problems, when paths are incorrectly treated by IDEA

This pull request has now been integrated.

Changeset: 159cb6fa
Author:    Nikita Gubarkov <Nikita.Gubarkov at jetbrains.com>
Committer: Alexey Ushakov <avu at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/159cb6facc668acc30552665e46b18edf58c3a91
Stats:     219 lines in 11 files changed: 107 ins; 47 del; 65 mod

8268083: JDK-8267706 breaks bin/idea.sh on a Mac

Reviewed-by: erikj

-------------

PR: https://git.openjdk.java.net/jdk/pull/4369