RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home [v2]

[ScientificWare]

On Tue, 8 Jun 2021 12:37:27 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changes to keep home_dtd null check.
>>   
>>   As suggested in conversation moving `+ File.separator` is more elegant than changing the `null` check.
>
> make/jdk/src/classes/build/tools/dtdbuilder/DTDBuilder.java line 287:
> 
>> 285: 
>> 286:         String dtd_home = System.getProperty("dtd_home") + File.separator;
>> 287:         if (dtd_home.equals("null" + File.separator)) {
> 
> dtd_home is only used in one location, so instead of changing this null check, maybe just move the "+ File.separator" to line 295?

You are right. Thanks for this suggestion and reviewing.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3626