RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home [v2]

[Erik Joelsson]

On Wed, 9 Jun 2021 00:42:35 GMT, ScientificWare <github.com+19194678+scientificware at openjdk.org> wrote:

>> This concerns [dtdbuilder tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder).
>> 
>> In jshell, try `System.getProperty("html32") + ""` you'll get a `String`.
>> 
>> So, in `DTDBuilder.java` when none `dtd_home` property is set, the `dtd_home` string value is not `null`, causing an exception with the present test.
>> 
>> The expected value is `"Must set property 'dtd_home'"`
>> 
>> And in this case, should'nt we have a `System.exit(1)` too rather than a simple `return` ?
>
> ScientificWare has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changes to keep home_dtd null check.
>   
>   As suggested in conversation moving `+ File.separator` is more elegant than changing the `null` check.

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/3626