Integrated: 8268083: JDK-8267706 breaks bin/idea.sh on a Mac

[Maurizio Cimadamore]

Seems like another big change is that we try to create an IDE module per 
imported JDK module.

Again, whether this is feasible or not is something which deserves more 
discussion. At the moment it just doesn't work.

Maurizio

On 15/06/2021 14:26, Maurizio Cimadamore wrote:
> This PR removes support for the Ant support file. Without that, many 
> of the IDE actions are no longer working. Jtreg plugin support seems 
> broken as well, as you can no longer select which build target has to 
> be executed before the tests are run.
>
> I think I'm a bit concerned by these changes, in the sense that they 
> tweak quite a lot of the functionality of the IDE project, in ways 
> which makes them no longer working, and, more generally, this PR does 
> a lot more than just replacing realpath, it seems.
>
> I think we should back this out, and have a wider discussion (possibly 
> using ide-support mailing list) as to whether some of the features in 
> this PR are worth pursuing.
>
> As things stand, I can no longer use the IDE in a way which works.
>
> Maurizio
>
> On 08/06/2021 15:39, Nikita Gubarkov wrote:
>> On Fri, 4 Jun 2021 21:23:27 GMT, Nikita Gubarkov 
>> <github.com+9004656+YaaZ at openjdk.org> wrote:
>>
>>> I got rid of `realpath` usage as discussed in 
>>> https://github.com/openjdk/jdk/pull/4190 and used `RelativePath` 
>>> macro instead, however there were quite a few problems with this 
>>> macro, here's the example:
>>>
>>> $(call RelativePath,/foo/bar,/foo/bar/baz) -> " ..//foo/bar"
>>> $(call RelativePath,/foo/bar/baz/,/foo/bar/baz) -> SEGFAULT
>>> $(call RelativePath,/foo/bar/baz/banan,/foo/bar/) -> " ./baz/banan"
>>> $(call RelativePath,/foo/bar/baz,/foo/bar/banan) -> " ../baz"
>>>
>>> As you can see, 1st case is just plain wrong, 2nd crashes make 
>>> because of infinite loop, 3rd can be simplified and all of them have 
>>> leading whitespaces
>>> First commit in this PR fixes all these issues and adds 
>>> corresponding test cases and second commit replaces usage of 
>>> `realpath` in idea.sh with `RelativePath` macro in idea.gmk and 
>>> fixes problems, when paths are incorrectly treated by IDEA
>> This pull request has now been integrated.
>>
>> Changeset: 159cb6fa
>> Author:    Nikita Gubarkov <Nikita.Gubarkov at jetbrains.com>
>> Committer: Alexey Ushakov <avu at openjdk.org>
>> URL: 
>> https://git.openjdk.java.net/jdk/commit/159cb6facc668acc30552665e46b18edf58c3a91
>> Stats:     219 lines in 11 files changed: 107 ins; 47 del; 65 mod
>>
>> 8268083: JDK-8267706 breaks bin/idea.sh on a Mac
>>
>> Reviewed-by: erikj
>>
>> -------------
>>
>> PR: https://git.openjdk.java.net/jdk/pull/4369