[jdk17] RFR: 8269037: jsig/Testjsig.java doesn't have to be restricted to linux only

David Holmes dholmes at openjdk.java.net
Mon Jun 21 00:33:25 UTC 2021


On Sun, 20 Jun 2021 11:08:21 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review this small patch that enables `runtime/jsig/Testjsig.java` test and compilation of its native library on all platforms but windows?
> from JBS:
>> `runtime/jsig/Testjsig.java` test currently `@requires (os.family == "linux")` and `test/hotspot/jtreg/runtime/jsig/libTestJNI.c` compilation is resticted to linux only, howere there seems to be nothing in the test code that prevents it from execution on a system that supports POSIX.
> 
> testing:  `runtime/jsig/Testjsig.java` on `{linux,windows,macosx}-x64`
> 
> 
> Thanks,
> -- Igor

Hi Igor,

The changes seem fine but it seems risky to me to push this to 17 at this late stage as we don't know what quirks this test might expose on macOS.

Thanks,
David

-------------

PR: https://git.openjdk.java.net/jdk17/pull/105



More information about the build-dev mailing list