[jdk17] RFR: 8269148: Update minor GCC version in GitHub Actions pipeline

[David Holmes]

On 23/06/2021 5:38 am, Xin Liu wrote:
> On Tue, 22 Jun 2021 17:20:14 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> 
>> It seems Ubuntu had bumped the version for GCC, so GHA started to fail with e.g.:
>>
>>
>> The following packages have unmet dependencies:
>>   g++-10-s390x-linux-gnu : Depends: gcc-10-s390x-linux-gnu-base (= 10.2.0-5ubuntu1~20.04cross1) but 10.3.0-1ubuntu1~20.04cross1 is to be installed
>>   gcc-10-s390x-linux-gnu : Depends: cpp-10-s390x-linux-gnu (= 10.2.0-5ubuntu1~20.04cross1) but 10.3.0-1ubuntu1~20.04cross1 is to be installed
>>                            Depends: gcc-10-s390x-linux-gnu-base (= 10.2.0-5ubuntu1~20.04cross1) but 10.3.0-1ubuntu1~20.04cross1 is to be installed
>> E: Unable to correct problems, you have held broken packages.
>> Error: Process completed with exit code 100.
>>
>>
>> I believe we should just update to `10.3.0-1ubuntu1~20.04`.
>>
>> Additional testing:
>>   - [x] GitHub Actions, package installation steps work
>>   - [ ] GitHub Actions, the builds complete
> 
> .github/workflows/submit.yml line 175:
> 
>> 173:         run: |
>> 174:           sudo apt-get update
>> 175:           sudo apt-get install gcc-10=10.3.0-1ubuntu1~20.04 g++-10=10.3.0-1ubuntu1~20.04 libxrandr-dev libxtst-dev libcups2-dev libasound2-dev
> 
> One dummy question:
> Why do we need to specify the real package name here?
> If we install gcc-10, I think apt system will pick up the latest gcc-10 for us.

IIRC the intent is to keep control over the gcc version and not randomly 
update whenever the distro updates. Upgrading compiler versions for the 
OpenJDK is actually a very involved process when done properly and we 
often find code changes need to be made, or warnings adjusted, when a 
new version of the compiler is to be used. This approach forces us to 
check the new version is okay before switching over to it. At least that 
is the theory. :)

Cheers,
David



> -------------
> 
> PR: https://git.openjdk.java.net/jdk17/pull/120
>