RFR: 8268821: Split systemDictionaryShared.cpp

David Holmes david.holmes at oracle.com
Wed Jun 23 06:45:03 UTC 2021


Hi Yumin,

On 23/06/2021 4:19 pm, Yumin Qi wrote:
> Hi, Please review
> systemDictionaryShared becomes fatter and fatter so it is time to split it into functional files. Moved security and jar operation related code into CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to sharedClassInfo.[ch]pp, also moved lambda proxy related to lambdaProxyClassInfo.hpp. This way systemDictionaryShared.cpp looks neat and light.

I'm not really seeing a consistent or recognisable naming pattern here. 
We seem to have a mix of:

- cds/foo.cpp
- cds/fooShared.cpp
- cds/sharedFoo.cpp

Can we establish a simple naming scheme here?

Thanks,
David

> Tests: tier1,tier3,tier4
> 
> Thanks
> Yumin
> 
> -------------
> 
> Commit messages:
>   - 8268821: Split systemDictionaryShared.cpp
> 
> Changes: https://git.openjdk.java.net/jdk/pull/4568/files
>   Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4568&range=00
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8268821
>    Stats: 2606 lines in 11 files changed: 1310 ins; 1101 del; 195 mod
>    Patch: https://git.openjdk.java.net/jdk/pull/4568.diff
>    Fetch: git fetch https://git.openjdk.java.net/jdk pull/4568/head:pull/4568
> 
> PR: https://git.openjdk.java.net/jdk/pull/4568
> 



More information about the build-dev mailing list