RFR: 8268821: Split systemDictionaryShared.cpp [v2]

[Calvin Cheung]

On Wed, 23 Jun 2021 20:45:49 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Hi, Please review
>> systemDictionaryShared becomes fatter and fatter so it is time to split it into functional files. Moved security and jar operation related code into CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to sharedClassInfo.[ch]pp, also moved lambda proxy related to lambdaProxyClassInfo.hpp. This way systemDictionaryShared.cpp looks neat and light.
>> 
>> Tests: tier1,tier3,tier4
>> 
>> Thanks
>> Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Split further sharedClassInfo.hpp to dumpTimeSharedClassInfo.hpp and runTimeSharedClassInfo.hpp to conform to simple rule of separation of definition and implementation

Looks good. Few minor comments.

src/hotspot/share/cds/cdsProtectionDomain.cpp line 34:

> 32: #include "classfile/vmClasses.hpp"
> 33: #include "classfile/vmSymbols.hpp"
> 34: #include "classfile/symbolTable.hpp"

Please move line 34 before line 31.

src/hotspot/share/cds/dumpTimeSharedClassInfo.hpp line 31:

> 29: #include "cds/archiveBuilder.hpp"
> 30: #include "cds/archiveUtils.hpp"
> 31: #include "cds/metaspaceShared.hpp"

Please move line 28 after line 31.

src/hotspot/share/cds/metaspaceShared.cpp line 35:

> 33: #include "cds/lambdaFormInvokers.hpp"
> 34: #include "cds/metaspaceShared.hpp"
> 35: #include "cds/cdsProtectionDomain.hpp"

This line should be after line 27.

src/hotspot/share/classfile/systemDictionaryShared.hpp line 291:

> 289:   static void start_dumping() NOT_CDS_RETURN;
> 290:   static bool is_supported_invokedynamic(BootstrapInfo* bsi) NOT_CDS_RETURN_(false);
> 291:   static void dd_to_dump_time_lambda_proxy_class_dictionary(LambdaProxyClassKey key, InstanceKlass* proxy_klass);

I don't think this is being referenced.

-------------

Changes requested by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4568