RFR: 8263136: C4530 was reported from VS 2019 at access bridge

Thomas Stuefe stuefe at openjdk.java.net
Mon Mar 8 06:28:07 UTC 2021


On Sun, 7 Mar 2021 22:00:41 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > I wondered why C++ std headers are even used. The source code looks C-ish; but "8196681: Java Access Bridge logging and debug flags dynamically controlled" added some coding, adding a bunch of C++11x semantics and included C++ std headers. Using "/Ehsc" had even been discussed: https://mail.openjdk.java.net/pipermail/awt-dev/2018-December/014847.html but not done.
> 
> After that discussion the usage of "string.h"/etc was dropped and "C string manipulation API" was used instead, and that suppressed the warning. I do not know why it was not complaining about "getTimeStamp". I think the fix should refactor the code again.

Ah, I missed that part. Thanks for clarifying the history :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/2859



More information about the build-dev mailing list