RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v13]
Ajit Ghaisas
aghaisas at openjdk.java.net
Fri Mar 12 04:20:26 UTC 2021
On Fri, 12 Mar 2021 01:04:22 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 47 additional commits since the last revision:
>>
>> - Lanai PR#214 - 8263324 - avu
>> - Merge branch 'master' into 8260931_lanai_JEP_branch
>> - Lanai PR#213 - 8263325 - avu
>> - Lanai PR#212 - 8259825 - aghaisas
>> - Lanai PR#211 - 8262882 - aghaisas
>> - Merge branch 'master' into 8260931_lanai_JEP_branch
>> - Lanai PR#210 - 8263159 - jdv
>> - Lanai PR#209 - 8262936 - jdv
>> - Lanai PR#208 - 8262928 - jdv
>> - Lanai PR#207 - 8262750 - jdv
>> - ... and 37 more: https://git.openjdk.java.net/jdk/compare/23f9642d...369c3d21
>
> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.m line 813:
>
>> 811: initTemplatePipelineDescriptors();
>> 812: // This block is not reached in current implementation.
>> 813: // Texture paint XOR mode rendering uses a tile based rendering using a SW pipe (similar to OGL)
>
> Do we have a bugid to implement this later?
This is not exactly a TODO which we intend to implement later. Hence, there is no bugid.
Metal does not support XOR mode rendering. I have kept this code as to know the code path to take in case we need to implement it in future.
> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceDataBase.h line 59:
>
>> 57: * The offset in pixels of the Metal viewport origin from the lower-left
>> 58: * corner of the heavyweight drawable. For example, a top-level frame on
>> 59: * Windows XP has lower-left insets of (4,4). The Metal viewport origin
>
> Do we really use these fields? "Windows XP"??
This will be fixed as a follow-on issue - JDK-8263486.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2403
More information about the build-dev
mailing list