Integrated: 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Mar 12 09:50:16 UTC 2021


Hi Yumin,

While this fix corrected the actual problem, the end result is that the 
checking message went from slightly misleading to outright wrong.

Instead of
AC_MSG_CHECKING([if CDS archive is available]) it should read like this:

AC_MSG_CHECKING([if CDS region alignment is available]) Can you please 
fix this in a follow-up bug? (And while you are at it, please change 
"cds" to "CDS" in the other messages; we are using the capitalized 
version of this acronym everywhere else in messages directed to the user.)

/Magnus

On 2021-03-11 20:00, Yumin Qi wrote:
> On Thu, 11 Mar 2021 18:41:10 GMT, Yumin Qi <minqi at openjdk.org> wrote:
>
>> Hi, Please review
>>
>>    JDK-8236847 changes failed on build linux-aarch64 on xcross build. The reason is we check BUILD_CDS_ARCHIVE which is not correct in such case. We should check ENABLE_CDS instead.
>>
>> Thanks
>> Yumin
> This pull request has now been integrated.
>
> Changeset: 15daccac
> Author:    Yumin Qi <minqi at openjdk.org>
> URL:       https://git.openjdk.java.net/jdk/commit/15daccac
> Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod
>
> 8263465: JDK-8236847 causes tier1 build failure on linux-aarch64
>
> Reviewed-by: iklam, erikj, dcubed
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/2946




More information about the build-dev mailing list