RFR: 8265909 : build.tools.dtdbuilder.DTDBuilder.java failed detecting missing path of dtd_home

[ScientificWare]

On Thu, 22 Apr 2021 13:47:03 GMT, ScientificWare <github.com+19194678+scientificware at openjdk.org> wrote:

> This concern [dtdbuilder tools](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder).
> 
> In jshell, try `System.getProperty("html32") + ""` you'll get a `String`.
> 
> So, in `DTDBuilder.java` when none `dtd_home` property is set, the `dtd_home` string value is not `null`, causing an exception with the present test.
> 
> The expect value is `"Must set property 'dtd_home'"`
> 
> And in this case, should'nt we have a `System.exit(1)` too rather than a simple `return` ?

Simple reproducer :

In raw mode, save the 4 java files from [https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilde](https://github.com/openjdk/jdk/tree/master/make/jdk/src/classes/build/tools/dtdbuilder) in the folder `/test_dtdbuilder` for example.

In this folder type following commands :
`javac -d . *.java`
`java build.tools.dtdbuilder.DTDBuilder html32`

-------------

PR: https://git.openjdk.java.net/jdk/pull/3626