RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

Thu May 6 17:27:53 UTC 2021

On Thu, 6 May 2021 16:38:52 GMT, Phil Race <prr at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   switch off warning in build instead of fixing it
>
> The policy is to do what you ended up doing. We (almost) never modify 3rd party sources in such cases.
> About the only case is if a fix has already been pushed upstream then we might copy that fix.
> You did the right thing notifying upstream but still best to just disable this warning for now.

Thanks @prrace. I agree this is the simplest way. Good that Aleksey had this idea.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3873