RFR: 8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font

Phil Race prr at openjdk.java.net
Thu May 20 16:25:33 UTC 2021


On Tue, 18 May 2021 19:53:36 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> See the bug report for lots of explanation.
>> The short version (not that short) is that Swing adds a new line char to editable TextComponents
>> It used to work because harfbuzz asked CoreText which mapped it to an invisible glyph
>> Now harfbuzz does its own processing of AAT fonts it is different.
>> Harfbuzz looks up the mapping for this but there is none so it gets a missing glyph.
>> 
>> Solution: Since HB now does AAT processing we can dispense with all the special handling of that case
>> and core text and just treat AAT fonts like OT fonts. 
>> This means its gets the same mapping we get when not using Layout.
>> 
>> And the test passes on all platforms .. not just macOS ..
>
> src/java.desktop/share/native/libharfbuzz/hb-coretext.cc line 1:
> 
>> 1: /*
> 
> How we will track these files for the next HB update? Do we need to document it somehow? otherwise, I think it will be added again as a new files.

No, they won't. We already pull in only the files we need, not every file, so this is not a precedent.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4097



More information about the build-dev mailing list