RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v10]

[Jorn Vernee]

On Mon, 1 Nov 2021 15:38:18 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17 commits:
>> 
>>  - Add cache for memory address var handles
>>  - Merge branch 'master' into JEP-419
>>  - Fix regression in VaList treatment on AArch64 (contributed by @nick-arm)
>>  - Merge branch 'master' into JEP-419
>>  - Fix copyright header in TestArrayCopy
>>  - Fix failing microbenchmarks. Contributed by @FrauBoes (thanks!)
>>  - * use `invokeWithArguments` to simplify new test
>>  - Add test for liveness check with high-aririty downcalls
>>    (make sure that if an exception occurs in a downcall because of liveness,
>>    ref count of other resources are left intact).
>>  - * Fix javadoc issue in VaList
>>    * Fix bug in concurrent logic for shared scope acquire
>>  - Address review comments
>>  - ... and 7 more: https://git.openjdk.java.net/jdk/compare/5bb1992b...9b519343
>
> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java line 1035:
> 
>> 1033:      *
>> 1034:      * @param layout the layout of the memory region to be read.
>> 1035:      * @param offset offset in bytes (relative to this segment). For instance, if this segment is a {@link #isNative()} segment,
> 
> Suggestion:
> 
>      * @param offset offset in bytes (relative to this segment). For instance, if this segment is a {@link #isNative() native} segment,

Same suggestion with all the other getters/setters below (I assume you wanted to add text to the link here?)

> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemorySegment.java line 1549:
> 
>> 1547:      * @param index index (relative to this segment). For instance, if this segment is a {@link #isNative()} segment,
>> 1548:      *               the final address of this write operation can be expressed as {@code address().toRowLongValue() + (index * layout.byteSize())}.
>> 1549:      * @param value the byte value to be written.
> 
> Suggestion:
> 
>      * @param value the address value to be written.

I think all the setters have this problem.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5907