RFR: 8276654: element-list order is non deterministic [v3]
Magnus Ihse Bursie
ihse at openjdk.java.net
Mon Nov 8 10:27:38 UTC 2021
On Sun, 7 Nov 2021 11:55:19 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:
>> Can someone please verify that the contents of these files after the fix is the same as the contents of the files for "good" builds before the fix?
>
>> Can someone please verify that the contents of these files after the fix is the same as the contents of the files for "good" builds before the fix?
>
> @jonathan-gibbons done, all good
@andrew-m-leonard Please refrain from force-pushing to a PR. It makes the evolution of the patch hard to follow for reviewers.
I thought I had commented on the commas, but I can't find it now so maybe I failed to press the Comment button. So let me do it again.
Can you verify if it is possible to add whitespace after the commas in the "sequence" call? Normally, we use whitespace after all commas (except where impossible, like for built-in make functions). If that does not work, we need to fix the "sequence" method so it accepts whitespace after commas.
Otherwise this looks good!
-------------
PR: https://git.openjdk.java.net/jdk/pull/6278
More information about the build-dev
mailing list