RFR: 8276672: Cannot build hsdis on WSL [v3]
Magnus Ihse Bursie
ihse at openjdk.java.net
Wed Nov 10 11:52:39 UTC 2021
On Wed, 10 Nov 2021 01:41:03 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
>> JDK-8275128 introduced new Makefile for hsdis to integrate it to normal build system, however it does not work on WSL 1 Ubuntu 20.04 and MinGW from Ubuntu.
>>
>> Hsdis.gmk has two problems:
>>
>> 1. MinGW version is fixed to "9.2.0"
>> 2. Assumes sysroot for MinGW is located at /usr/$MINGW_BASE/sys-root
>>
>> I tested this change on WSL only, so it is appreciate to review on Cygwin.
>
> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove SYSROOT_FLAGS
Great! I missed the redundant `SYSROOT_FLAGS`, thanks for taking care of that.
-------------
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6269
More information about the build-dev
mailing list