RFR: 8276854: Windows GHA builds fail due to broken Cygwin
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Wed Nov 10 13:49:26 UTC 2021
https://openjdk.java.net/census#build
On 2021-11-10 08:48, Aleksey Shipilev wrote:
> On Tue, 9 Nov 2021 20:47:29 GMT, Anirvan Sarkar <asarkar at openjdk.org> wrote:
>
>> Use version `3.2.0` of `cygwin` instead of latest version `3.3.2` on GitHub Actions.
>> `make` SEGVs on the latest version.
>>
>> Version number format obtained from https://cygwin.com/packages/summary/cygwin.html
> The patch looks okay.
>
> But what just happened here process-wise? Please do *not* take the issue out of assignee's hands without asking first, and definitely do *NOT* push the fix until the original assignee at least performs some sort of handover. Especially don't do that in the span of less than 24 hours, where the assignee might just be asleep. I also suspect the build infra changes require more reviews, anyway. Don't rush it, folks!
I would like to add to Aleksey's comment that the ideal is that you get
a review from someone in the Build Group
(https://openjdk.java.net/census#build). You definitely need to wait 24h
if you have no Build Group member reviews., unless the PR is extremely
urgent.
/Magnus
>
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/6319
More information about the build-dev
mailing list