RFR: 8276927: [PPC64] Port shenandoahgc to linux on ppc64le

Roman Kennke rkennke at openjdk.java.net
Thu Nov 11 12:10:41 UTC 2021


On Wed, 10 Nov 2021 09:00:04 GMT, Niklas Radomski <nradomski at openjdk.org> wrote:

> Port the Shenandoah garbage collector (JDK-8241457)[https://bugs.openjdk.java.net/browse/JDK-8241457] to linux on ppc64le.

Hi Niklas,
thanks for this awesome work!
I can't really comment on the actual PPC code, so this needs to be reviewed by somebody else. Structurally the change looks correct. I have one comment about the C1 CAS barrier code, but it's minor.

Thanks & cheers,
Roman

src/hotspot/cpu/ppc/gc/shenandoah/c1/shenandoahBarrierSetC1_ppc.cpp line 83:

> 81:     LIRGenerator* gen = access.gen();
> 82: 
> 83:     if (ShenandoahCASBarrier) {

I am not sure, but I almost think we should not even end up in the method with -ShenandoahCASBarrier. If anything, -ShenandoahCASBarrier should result in only calling super to emit regular CAS without any barriers.

-------------

Marked as reviewed by rkennke (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6325



More information about the build-dev mailing list