RFR: 8275745: Reproducible copyright headers

Emmanuel Bourg duke at openjdk.java.net
Thu Nov 11 15:16:00 UTC 2021


On Thu, 11 Nov 2021 13:45:21 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Yes that's fine. I guess this involves setting the `COPYRIGHT_YEAR` variable in `make/autoconf/jdk-options.m4` to a value derived from `SOURCE_DATE_EPOCH` (with `SOURCE_DATE_EPOCH` having the priority over `--with-copyright-year` or the opposite?), and then pick the value of `COPYRIGHT_YEAR` in `CopyrightHeaders.java` and `EquivMapsGenerator.java`, right?
>
> @ebourg I have now modified this patch so it uses COPYRIGHT_YEAR, and sets COPYRIGHT_YEAR based on SOURCE_DATE_EPOCH, if it exists. The patch is in a branch in my personal fork, https://github.com/magicus/jdk/tree/reproducible-copyright-year.
> 
> If you think it looks good, we have two possible ways forward. Either you close this PR, and I open a new targeting the same JBS issue, and credit you as co-author. Or you integrate my branch into this PR, and credit me as co-author. Any of them is OK for me, but I think the former is simpler.

@magicus Thank you! I've integrated your branch

-------------

PR: https://git.openjdk.java.net/jdk/pull/1498



More information about the build-dev mailing list