RFR: 8276743: Make openjdk build Zip Archive generation "reproducible"
Andrew Leonard
aleonard at openjdk.java.net
Thu Nov 11 15:40:48 UTC 2021
On Wed, 10 Nov 2021 14:39:09 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> @erikj79 The flag --enable-reproducible-builds sets ENABLE_REPRODUCIBLE_BUILD in spec.gmk. This is set by our JIB profiles. I propose that we also turn it on for GHA builds.
>>
>> I think that the post-processing of the zip file can be dependent on this variable and that it serves no purpose to introduce a separate variable ENABLE_REPRODUCIBLE_ZIP that is set to the same value as ENABLE_REPRODUCIBLE_BUILD. Do you agree?
>
>> I think that the post-processing of the zip file can be dependent on this variable and that it serves no purpose to introduce a separate variable ENABLE_REPRODUCIBLE_ZIP that is set to the same value as ENABLE_REPRODUCIBLE_BUILD. Do you agree?
>
> Sure, that works for me.
@erikj79 @magicus I have just pushed a new commit with the suggested changes, and it works well, thank you for the help
I've also done a basic average benchmarking, on my rather slow Ubuntu VM:
- Existing src.zip processing : 18 seconds
- Additional MakeZipReproducible : 6 seconds
-------------
PR: https://git.openjdk.java.net/jdk/pull/6311
More information about the build-dev
mailing list