RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

[Phil Race]

On Thu, 11 Nov 2021 15:32:01 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set any deployment target when when we use xcrun to create .air file and this issue looks similar to https://developer.apple.com/forums/thread/105719. Also https://developer.apple.com/forums/thread/105719 states that even if they set app deployment target they need to explicitly set deployment in "xcrun metal".
>> 
>> Made same change to use -mmacosx-version-min=10.12.00 in our make file. Whether we should keep 10.12.00 or 10.13/14 is open to discussion for metal pipeline.
>> 
>> SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter) has confirmed that patch resolves the issue.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use Macro for version

make/modules/java.desktop/lib/Awt2dLibraries.gmk line 850:

> 848:       COMMAND := $(METAL) -c -std=osx-metal2.0 \
> 849:           -mmacosx-version-min=$(MACOSX_VERSION_MIN) \
> 850:           -o $(SHADERS_AIR) $(SHADERS_SRC), \

No .. we decided metal requires macos 10.14 as a minimum. In fact it won't run (by policy) on earlier releases so settting it to what the broader JDK defines as a minimum is not appropriate right now.
And I've no idea what restrictions we'd be placing on metal saying it can only use 10.12 features.
Nor do I know what the xcode 12.4 used to build JDK 17 defaults to and how much a change to either 10.12 or 10.14 might require in re-testing.

So - 
we should use 10.14 
what's the actual impact of that on a current build using xcode 12.4 - does it change anything we use ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6346